[ROMM-2184] Fix selecting dialog buttons on mobile #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes dialog button interaction issues on mobile devices by improving the layout and positioning of dialog components. The changes focus on removing fixed height constraints and restructuring button placement to make them more accessible on mobile screens.
- Removed fixed height constraints from dialogs to allow for better responsive behavior
- Moved dialog buttons to the append template for better mobile accessibility
- Added margin spacing to improve visual layout of loading and empty states
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SearchCover.vue | Removed fixed height constraint for mobile responsiveness |
| RDialog.vue | Added margin spacing to loading and empty state rows for better visual layout |
| MatchRom.vue | Restructured button layout by moving buttons to append template and removing fixed height |
| EditRom.vue | Cleaned up unused display breakpoint import |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2184
Checklist
Please check all that apply.
Screenshots