[ROMM-2186] Allow editing user without password field #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ability to edit users without requiring a password field to be filled, addressing issue #2186. The main change allows administrators to edit user information while optionally updating the password.
- Adds internationalization support for "edit-user" text and password placeholder text across all supported locales
- Modifies the edit user dialog to make password field optional with helpful placeholder text
- Updates the edit button in the users table to include a descriptive title
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/locales/*/settings.json | Adds translations for "edit-user" and "password-placeholder" keys across all supported languages |
| frontend/src/components/Settings/Administration/Users/Table.vue | Adds tooltip title to the edit user button |
| frontend/src/components/Settings/Administration/Users/Dialog/EditUser.vue | Makes password field optional and adds dialog header with proper internationalization |
frontend/src/components/Settings/Administration/Users/Dialog/EditUser.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2186
Checklist
Please check all that apply.
Screenshots