feat: Missing roms admin panel #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated logotipo images (PNG and SVG) for improved branding. - Upgraded Vuetify version from 3.7.18 to 3.9.2 in package.json and package-lock.json. - Removed MissingGames component and integrated game table for better display of missing ROMs. - Enhanced LibraryManagement.vue to include platform filtering and improved loading states. - Refactored fetchRoms function to handle pagination and loading states more effectively. - Changed data table from v-data-table-server to v-data-table-virtual for performance optimization.
…tion in LibraryManagement
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
890bf75 to
60837b4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a missing ROMs admin panel in the Library Management view, allowing administrators to easily manage and remove missing files from the filesystem. The changes include updating component imports to a new Config subfolder structure, replacing the game table component with a virtual table, and upgrading Vuetify.
- Adds tabbed interface with Config and Missing games sections
- Implements missing ROMs filtering, display, and bulk cleanup functionality
- Updates component organization by moving files to Config subfolder
Reviewed Changes
Copilot reviewed 8 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Settings/LibraryManagement.vue | Main view updated with tabs and missing games functionality |
| frontend/src/stores/roms.ts | Enhanced with new fetch parameters and limit setting |
| frontend/src/components/common/Game/Table.vue | Changed from server-side to virtual data table |
| frontend/src/components/common/Game/Card/Base.vue | Simplified cover display logic |
| frontend/src/components/Settings/LibraryManagement/Config/*.vue | Updated imports to reflect new folder structure |
| frontend/package.json | Vuetify version upgraded from 3.7.18 to 3.9.2 |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/stores/roms.ts:104
- [nitpick] The parameter name 'groupRoms' is ambiguous in the context of a fetch function. Consider renaming to 'shouldGroupRoms' or 'enableGrouping' to be more descriptive.
groupRoms?: boolean,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the first iteration of the
missing games admin panel. Now in theLibrary Managementview, admins can manage/remove missing files from the filesystem easily.This PR also replaces the
isotipoandlogotipowith the new versions and make a couple of little UX improvements.Checklist
Please check all that apply.
Screenshots