[ROMM-2127] Add missing ssfr platform and fix IDs #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ScreenScraper platform mapping by correcting platform IDs and adding missing platform support. The changes address issue #2127 by updating the ScreenScraper platform dictionary with accurate IDs and adding support for the Nintendo 64DD platform.
- Corrected ScreenScraper platform IDs for Amiga CD32 and CPC platforms
- Added new platform mappings for Amiga CD and Nintendo 64DD
- Updated EJS supported platforms list to include the new platforms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/handler/metadata/ss_handler.py | Updated SCREENSAVER_PLATFORM_LIST with corrected IDs and new platform entries |
| backend/handler/database/roms_handler.py | Added new platforms to EJS_SUPPORTED_PLATFORMS list |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Test Results496 tests 495 ✅ 57s ⏱️ Results for commit b693f05. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
LGTM. |
danblu3
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2127
Checklist
Please check all that apply.
Screenshots