More service adapter tests #2139
Conversation
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
48abaf9 to
696ba42
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
add ssfr and sgdb service test
696ba42 to
b92ecd8
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for service adapters including SteamGridDB, ScreenScraper, MobyGames, and RetroAchievements. The changes improve testing infrastructure and provide thorough validation of service adapter functionality across unit, integration, and edge case scenarios.
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pytest.ini | Adds environment variables for new service adapter API keys |
| test_steamgriddb.py | Complete test suite for SteamGridDB service including middleware, units tests, integration tests |
| test_screenscraper.py | Complete test suite for ScreenScraper service with authentication and error handling tests |
| test_mobygames.py | Comprehensive MobyGames service tests covering all API methods and edge cases |
| test_retroachivements.py | Removes duplicate fixture and improves existing RetroAchievements tests |
| conftest.py | Shared test fixture for aiohttp session management across all service tests |
| Multiple VCR cassettes | Recorded API responses for deterministic integration testing |
Comments suppressed due to low confidence (1)
backend/adapters/services/tests/test_mobygames.py:17
- The type alias MockResponse is overly specific and doesn't match all actual usage patterns in the file. Consider using a more generic type or Union type to better represent the varied response structures.
MockResponse = dict[str, list[dict[str, int]]]
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots