Skip to content

feat: Added clean resources task + revamped the whole task system #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2025
Merged

feat: Added clean resources task + revamped the whole task system #2135

merged 5 commits into from
Jul 22, 2025

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jul 22, 2025 •
edited
Loading

Description
This PR adds a task that will cleanup the resources folder to save space and remove the leftovers or orphaned resources.

Also the task system has been reworked. Now the tasks are auto discovered and a new endpoint was aded to get all the available tasks.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

@zurdi15 zurdi15 requested review from gantoine and adamantike July 22, 2025 16:47
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 22, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

Test Results

336 tests   336 ✅  47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b856fd1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8077 5319 66% 0% 🟢

New Files

File Coverage Status
backend/endpoints/responses/tasks.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
backend/endpoints/heartbeat.py 100% 🟢
backend/endpoints/responses/heartbeat.py 100% 🟢
backend/endpoints/tasks.py 100% 🟢
backend/handler/metadata/base_hander.py 57% 🟢
backend/handler/metadata/launchbox_handler.py 40% 🟢
TOTAL 79% 🟢

updated for commit: b856fd1 by action🐍

gantoine
gantoine approved these changes Jul 22, 2025
View reviewed changes
zurdi15 and others added 2 commits July 22, 2025 21:43
@zurdi15 @gantoine
Update backend/tasks/manual/cleanup_orphaned_resources.py
8ffe3af 
Co-authored-by: Georges-Antoine Assi <3247106+gantoine@users.noreply.github.com>
@zurdi15
fix: trunk check
b856fd1
@zurdi15 zurdi15 merged commit c1565fc into master Jul 22, 2025
10 checks passed
@zurdi15 zurdi15 deleted the feature/clean-resources-task branch July 22, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

@adamantike adamantike Awaiting requested review from adamantike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zurdi15 @gantoine