[ROMM-1230] Add background color picker to ruffle #2129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a background color picker feature to the Ruffle player, allowing users to customize the background color of the Flash player and persist their preference per ROM.
- Introduces a color picker UI component that appears when the game is not running
- Implements localStorage persistence for background color preferences per ROM
- Updates internationalization files with new translation keys for the background color feature
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/views/Player/RuffleRS/Base.vue | Main implementation with color picker UI, state management, and localStorage integration |
| frontend/src/locales/*/play.json | Translation updates for "background-color" and "select-background-color" across all supported languages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #1230
Checklist
Please check all that apply.
Screenshots