[ROMM-1975] Add YOUTUBE_BASE_URL for custom youtube proxy #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configurable YouTube proxy base URLs, allowing users to use YouTube alternatives like Piped or Invidious instead of the default YouTube domain.
- Introduces
YOUTUBE_BASE_URLenvironment variable with default value "https://www.youtube.com" - Updates frontend YouTube iframe sources to use the configurable base URL
- Adds configuration plumbing from backend environment to frontend via heartbeat endpoint
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| env.template | Adds YOUTUBE_BASE_URL environment variable documentation |
| backend/config/init.py | Defines YOUTUBE_BASE_URL configuration with default value and trailing slash removal |
| backend/endpoints/heartbeat.py | Includes YOUTUBE_BASE_URL in heartbeat response |
| backend/endpoints/responses/heartbeat.py | Adds YOUTUBE_BASE_URL to FrontendDict type definition |
| frontend/src/stores/heartbeat.ts | Sets default YOUTUBE_BASE_URL value in heartbeat store |
| frontend/src/components/Details/Info/GameInfo.vue | Replaces hardcoded YouTube URLs with configurable base URL |
Files not reviewed (2)
- frontend/src/generated/models/ConfigResponse.ts: Language not supported
- frontend/src/generated/models/FrontendDict.ts: Language not supported
Comments suppressed due to low confidence (2)
frontend/src/components/Details/Info/GameInfo.vue:13
- [nitpick] The import name 'storeHeartbeat' is inconsistent with typical Pinia store naming conventions. Consider renaming to 'useHeartbeatStore' to match the naming pattern used for the variable on line 24.
import storeHeartbeat from "@/stores/heartbeat";
frontend/src/components/Details/Info/GameInfo.vue:25
- [nitpick] The destructured property name 'value: heartbeat' is unclear. Consider using a more descriptive name like 'heartbeatData' or 'heartbeatConfig' to better indicate what this represents.
const { value: heartbeat } = storeToRefs(heartbeatStore);
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #1975
Checklist
Please check all that apply.
Screenshots