Group generated platforms by slug and filter by name #2124
Merged
+33
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the platform generation logic to use slugs as dictionary keys instead of platform names, ensuring consistent platform identification and deduplication across different metadata sources.
- Changes the primary key for
supported_platformsdictionary from platform names to lowercase slugs - Simplifies conditional logic by removing duplicate name-based checks
- Updates sorting to use the platform's name field instead of the dictionary key
- Corrects platform names for better consistency ("Adam" → "Coleco Adam", "64DD" → "Nintendo 64DD")
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/utils/generate_supported_platforms.py | Refactors platform grouping to use slugs as keys and updates sorting logic |
| backend/handler/metadata/ss_handler.py | Updates platform name from "Adam" to "Coleco Adam" |
| backend/handler/metadata/igdb_handler.py | Updates platform name from "64DD" to "Nintendo 64DD" |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots