[ROMM-2114] Fix using symlinks on volumes #2123
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with symlink handling on mounted volumes by modifying the path validation logic to treat symlinks differently from regular files and directories. The change prevents symlinks from being resolved before validation, which was causing issues when symlinks pointed outside the mounted volume boundaries.
- Modified path validation to check symlinks differently than regular files/directories
- Added explicit error handling with descriptive error messages for paths outside base directory
- Updated path normalization approach to avoid premature symlink resolution
Test Results318 tests 318 ✅ 44s ⏱️ Results for commit 791939b. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
zurdi15
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2114
Checklist
Please check all that apply.
Screenshots