[ROMM-2109] Fix clicking on meta pills, use correct filters #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes clicking on meta pills in the game info component by standardizing filter type naming conventions from plural to singular forms and updating the filter query structure.
- Updated FilterType definitions from plural to singular/camelCase format (e.g., "genres" → "genre", "age_ratings" → "ageRating")
- Modified filter configuration objects to use the new singular filter keys
- Changed query parameter structure from generic filter/value pattern to specific filter-based parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/stores/galleryFilter.ts | Updates FilterType enum from plural to singular/camelCase naming |
| frontend/src/components/Details/Info/GameInfo.vue | Updates filter keys and query structure to match new naming convention |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
zurdi15
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2109
Checklist
Please check all that apply.
Screenshots