Skip to content

[ROMM-2118] Store last scan selected sources in storage #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jul 21, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2118

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

@gantoine gantoine requested review from zurdi15 and Copilot July 21, 2025 17:07
Copy link

trunk-io bot commented Jul 21, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to store and restore the last selected metadata sources for scanning in localStorage, improving user experience by remembering their previous selections.

  • Exports MetadataOption type for use across components
  • Implements localStorage-based persistence for scan metadata source selections
  • Updates scan initialization to restore previously selected metadata sources

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
frontend/src/stores/heartbeat.ts Exports MetadataOption type to make it available for other components
frontend/src/views/Scan.vue Adds localStorage persistence for metadata source selections and restores them on component initialization

@gantoine gantoine changed the title [ROMM-2118] store last scan selected sources in storage [ROMM-2118] Store last scan selected sources in storage Jul 21, 2025
@gantoine gantoine merged commit 31c873e into master Jul 21, 2025
8 checks passed
@gantoine gantoine deleted the romm-2118 branch July 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Change enabled DB defaults for scanning
2 participants