[HOTFIX] Fix uploading cover art manually #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This hotfix addresses manual cover art uploading functionality by refactoring the image handling logic and updating return types to use None instead of empty strings. The changes consolidate artwork processing into a dedicated method and ensure consistent null handling across the filesystem resource handlers.
- Refactored manual artwork upload handling to use a new centralized
store_artworkmethod - Changed return types from empty strings to
Nonefor better null handling consistency - Cleaned up debug print statements and unused imports
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
backend/handler/metadata/igdb_handler.py |
Removed debug print statement |
backend/handler/filesystem/tests/test_resources_handler.py |
Updated test assertions to expect None instead of empty strings and fixed method calls |
backend/handler/filesystem/resources_handler.py |
Changed return types to use None, added new store_artwork method, refactored build_artwork_path |
backend/handler/filesystem/base_handler.py |
Removed debug print statement |
backend/endpoints/rom.py |
Refactored artwork handling to use new store_artwork method, removed unused PIL import |
backend/endpoints/collections.py |
Updated to use new store_artwork method, removed unused PIL import |
fe03131 to
73545ff
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please check all that apply.