[ROMM-1780] Random game button #2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a random game button to the filter bar on platform, collection, and search views. The button allows users to get a random game based on their current context (platform, collection, or search term) and active filters.
- Adds a new
ContextualRandomBtncomponent that makes API calls to get a random game - Updates the gallery app bar to include the random button
- Refactors navigation button components to use utility CSS classes instead of custom styles
- Adds internationalization support for the "random" text across all supported languages
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/components/Gallery/AppBar/common/ContextualRandomBtn.vue |
New component implementing the random game functionality |
frontend/src/components/Gallery/AppBar/Base.vue |
Integrates the random button into the gallery app bar |
frontend/src/components/common/Navigation/*.vue |
Refactors button styling to use utility classes |
frontend/src/locales/*/common.json |
Adds "random" translation key across all supported languages |
frontend/src/components/common/Navigation/MainAppBar.vue |
Updates tabindex ordering and button positioning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR adds a random game button to the filter bar on platform, collection and search views. The selected game is based on the selection platform, collection or search term + the list of active filters. We make 1 request to get the total number of games, and another with a random offset and 1 returned game.
Checklist
Please check all that apply.
Screenshots