Skip to content

fix: SGDB cover fallback #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix: SGDB cover fallback #2087

merged 1 commit into from
Jul 16, 2025

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jul 16, 2025

Description
Fixed SGDB cover fallback

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

Copy link

trunk-io bot commented Jul 16, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@zurdi15 zurdi15 changed the title refactor: simplify game cover retrieval logic in SGDBBaseHandler fix: SGDB cover fallback Jul 16, 2025
Copy link

Test Results

168 tests   168 ✅  38s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 90c2479.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7918 4997 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/metadata/sgdb_handler.py 45% 🟢
TOTAL 45% 🟢

updated for commit: 90c2479 by action🐍

@zurdi15 zurdi15 merged commit 5dc82ab into master Jul 16, 2025
9 checks passed
@zurdi15 zurdi15 deleted the fix/fallback-cover-to-provider branch July 16, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants