Skip to content

Scan page icons #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

Scan page icons #2084

merged 3 commits into from
Jul 15, 2025

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jul 15, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

Screenshot 2025-07-15 at 6 03 48 PM Screenshot 2025-07-15 at 5 56 02 PM

@gantoine gantoine requested a review from Copilot July 15, 2025 22:52
Copy link

trunk-io bot commented Jul 15, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates scan page icons to improve the visual consistency and layout of scraper service indicators across multiple components. The changes focus on standardizing the appearance and positioning of icons for various gaming database services like IGDB, ScreenScraper, MobyGames, LaunchBox, RetroAchievements, and Hasheous.

  • Adds comprehensive scraper service icons to the scan results view
  • Standardizes icon styling and positioning across components
  • Removes unnecessary tabindex attributes for better accessibility
  • Reorders MobyGames and ScreenScraper display order in the details view

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
frontend/src/views/Scan.vue Adds multiple scraper service icons with consistent styling to scan results
frontend/src/components/Gallery/AppBar/Platform/PlatformInfoDrawer.vue Standardizes chip styling and removes tabindex attributes
frontend/src/components/Details/Title.vue Reorders scraper services and applies consistent styling

@gantoine gantoine merged commit f652c8a into master Jul 15, 2025
8 checks passed
@gantoine gantoine deleted the scan-page-icons branch July 15, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant