Update roms_metadata virtual table #2083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
Updates several layers of metadata handling and display to bring the roms_metadata virtual table and related UI/model logic in line with newly added providers.
- Multiply and conditionally render provider scores in the frontend.
- Combine YouTube IDs and introduce new
first_release_dateandcompaniesfields for Launchbox in backend models and handlers. - Add static IGDB platform and age‐rating maps and dedupe their definitions in the IGDB handler.
- Provide an Alembic migration that recreates the
roms_metadataview with updated calculations and fallbacks.
Reviewed Changes
Copilot reviewed 5 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/Details/Title.vue | Multiply raw scores by 10/20 and wrap them in an optional template block. |
| backend/models/rom.py | Combine IGDB and Launchbox YouTube IDs in one property. |
| backend/handler/metadata/launchbox_handler.py | Extract first_release_date, parse YouTube URLs, and build companies list. |
| backend/handler/metadata/igdb_handler.py | Introduce IGDB_PLATFORM_CATEGORIES, IGDB_AGE_RATING_ORGS, IGDB_AGE_RATINGS; remove duplicate block. |
| backend/alembic/versions/0045_roms_metadata_update.py | Create or replace the roms_metadata view with new JSONB/JSON logic and rating multipliers. |
Files not reviewed (11)
- frontend/src/generated/index.ts: Language not supported
- frontend/src/generated/models/Body_add_platform_api_platforms_post.ts: Language not supported
- frontend/src/generated/models/Body_add_user_api_users_post.ts: Language not supported
- frontend/src/generated/models/Body_delete_roms_api_roms_delete_post.ts: Language not supported
- frontend/src/generated/models/Body_update_platform_api_platforms__id__put.ts: Language not supported
- frontend/src/generated/models/Body_update_rom_api_roms__id__put.ts: Language not supported
- frontend/src/generated/models/Body_update_rom_user_api_roms__id__props_put.ts: Language not supported
- frontend/src/generated/models/PlatformSchema.ts: Language not supported
- frontend/src/generated/models/RomLaunchboxMetadata.ts: Language not supported
- frontend/src/generated/models/RomRAMetadata.ts: Language not supported
- frontend/src/generated/models/UserForm.ts: Language not supported
Comments suppressed due to low confidence (2)
backend/models/rom.py:302
- [nitpick] The variable
lb_video_idcould be renamed tolaunchbox_video_idfor clearer intent and consistency with the other provider names.
lb_video_id = (
backend/handler/metadata/launchbox_handler.py:75
- The key "Released" may not match the actual API response field (previous code used "ReleaseDate"). Please verify that
index_entrycontains "Released" or adjust to the correct key.
).timestamp()
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
The
roms_metadatavirtual table has fallen behind in recent releases (as we've added new providers), so this PR updates calculated fields accordingly.Checklist
Please check all that apply.
Screenshots