refactor: improve fuzzy matching in SGDBBaseHandler for game search #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SGDBBaseHandler to use a basic fuzzy matching approach when selecting game covers, and makes the cover-fetching method more flexible by parameterizing dimensions and types.
- Introduce
fuzzy_match_thresholdand adjust matching logic to use normalized substring checks and a length-difference threshold - Refactor
_get_game_coversto acceptdimensionsandtypesas parameters with defaults instead of hard-coded tuples - Update calls to
_get_game_coversto leverage the new signature
Comments suppressed due to low confidence (2)
backend/handler/metadata/sgdb_handler.py:34
- [nitpick] The name
fuzzy_match_thresholdimplies a general fuzzy algorithm but this value is only used to compare string lengths. Consider renaming tolength_difference_thresholdor implementing a true fuzzy matching method.
self.fuzzy_match_threshold: Final = 4
backend/handler/metadata/sgdb_handler.py:50
- The new fuzzy match behavior isn’t covered by existing tests. Please add unit tests for partial matches, exact matches, and edge cases around the threshold to ensure consistent behavior.
async def get_details_by_names(self, game_names: list[str]) -> SGDBRom:
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
gantoine
approved these changes
Jul 15, 2025
| ): | ||
| game_details = await self._get_game_covers( | ||
| game_id=game["id"], | ||
| game_name=game["name"], | ||
| types=(SGDBType.STATIC,), |
There was a problem hiding this comment.
nooooo i like getting the animated ones
…shtein distance sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed to fuzzy match on SGDB cover search when scanning for better results
Checklist
Please check all that apply.
Screenshots