Stop overwriting IDs on scan #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances ID handling during scans, standardizes metadata structures, and updates UI chip styling for better readability.
- Prevents unintentional overwrites by merging ID fields in
scan_handler.py - Introduces a shared
BaseRomTypedDict and refactors metadata handlers to extend it - Updates platform slug mapping with numeric IDs and adds filters for new IDs in the database handler
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/common/Game/Table.vue | Added text-white class to chips for improved contrast |
| frontend/src/components/common/Game/Card/Base.vue | Added text-white class to chips for improved contrast |
| backend/handler/scan_handler.py | Added prioritized ID merge logic to avoid overwriting existing IDs |
| backend/handler/metadata/ss_handler.py | Refactored SSRom to extend BaseRom for consistent optional fields |
| backend/handler/metadata/ra_handler.py | Refactored RAGameRom to extend BaseRom, added first_release_date |
| backend/handler/metadata/moby_handler.py | Refactored MobyGamesRom to extend BaseRom |
| backend/handler/metadata/launchbox_handler.py | Refactored LaunchboxRom to extend BaseRom |
| backend/handler/metadata/igdb_handler.py | Refactored IGDBRom to extend BaseRom |
| backend/handler/metadata/hasheous_handler.py | Refactored HasheousRom to extend BaseRom and expanded slug mapping |
| backend/handler/metadata/base_hander.py | Introduced shared BaseRom TypedDict |
| backend/handler/database/roms_handler.py | Updated filter_by_matched to include ra_id and hasheous_id |
Comments suppressed due to low confidence (3)
backend/handler/metadata/base_hander.py:60
- [nitpick] The name
BaseRomis generic; consider a more descriptive name (e.g.,CommonRomFields) to clarify its purpose and avoid ambiguity.
class BaseRom(TypedDict):
backend/handler/database/roms_handler.py:195
- Since you’ve extended the filter to include
ra_idandhasheous_id, consider updating the method docstring to explain the new behavior.
Rom.ra_id.isnot(None),
backend/handler/scan_handler.py:518
- The new ID merge logic in
rom_attrs.updateintroduces complex precedence; consider adding targeted unit tests to cover scenarios where existing IDs should be preserved.
rom_attrs.update(
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots