Only use first file in compressed game when calculating hashes #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that only the first file in a compressed game archive is used when computing hashes, and it also fixes the deletion flow on the homepage by correctly updating the store’s continue-playing list.
- Select and hash only the first valid file in zip, tar, and 7z archives.
- Rename the continue-playing setter in the frontend store and update calls.
- Update deletion dialog to remove deleted ROMs from both recent and continue-playing lists.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Home.vue | Fixed call to the renamed setContinuePlayingRoms action instead of the old setContinuePlayedRoms. |
| frontend/src/stores/roms.ts | Renamed setContinuePlayedRoms to setContinuePlayingRoms. |
| frontend/src/components/common/Game/Dialog/DeleteRom.vue | After removing ROM(s), also filter them out of both recent and continue-playing lists. |
| backend/handler/scan_handler.py | Switched from get_rom(rom_attrs) to lookup_rom(fs_rom["files"]). |
| backend/handler/metadata/hasheous_handler.py | Replaced get_rom with lookup_rom(files), extracting only the first valid file’s hashes. |
| backend/handler/filesystem/roms_handler.py | Early return/break in zip, tar, and 7z readers so only the first file is read for hashing. |
Comments suppressed due to low confidence (4)
backend/handler/metadata/hasheous_handler.py:204
- Add unit tests for
lookup_romto verify that when multiple files are provided, only the first valid file’s hashes are used in the returnedHasheousRom.
async def lookup_rom(self, files: list[RomFile]) -> HasheousRom:
frontend/src/components/common/Game/Dialog/DeleteRom.vue:76
- Add a component/unit test for the deletion flow to assert that both
recentRomsandcontinuePlayingRomsare correctly filtered when deleting ROMs.
romsStore.setContinuePlayingRoms(
backend/handler/filesystem/roms_handler.py:134
- Relying on the archive’s native order may be non-deterministic across tools. Consider sorting
z.namelist()(or filtering by file extension) before picking the first entry to ensure consistent behavior.
for file in z.namelist():
backend/handler/metadata/hasheous_handler.py:204
- [nitpick]
get_romwas replaced bylookup_rom— consider deprecating or removing the old method and updating any documentation/comments to avoid confusion.
async def lookup_rom(self, files: list[RomFile]) -> HasheousRom:
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Also fixes deleting game from the homepage.
Checklist
Please check all that apply.