I lied, more fixes #2071
Merged
I lied, more fixes #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for new “Hasheous” links, updates existing external URLs, and centralizes external data source listings in the GameInfo component.
- Wraps various scrapper IDs (LaunchBox, RA, Hasheous, etc.) in anchor tags with updated URLs across
PlatformInfoDrawer.vueandTitle.vue. - Introduces a computed
dataSourceslist andcoverImageSourceinGameInfo.vuefor the “Data provided by” section. - Extends backend models and response schemas to include
hasheous_idin identification logic and adds amoby_slugcomputed field.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/Gallery/AppBar/Platform/PlatformInfoDrawer.vue | Fixed ScreenScraper URL, switched Moby link to use moby_slug, and added RetroAchievements & Hasheous anchor links |
| frontend/src/components/Details/Title.vue | Wrapped LaunchBox, RA, and Hasheous chips in <a> with updated URLs |
| frontend/src/components/Details/Info/GameInfo.vue | Added dataSources & coverImageSource computed properties and new UI row for data attribution |
| backend/models/rom.py | Included hasheous_id in is_unidentified and is_fully_identified properties |
| backend/models/platform.py | Included ra_id and hasheous_id in platform identification logic |
| backend/endpoints/responses/platform.py | Imported MOBYGAMES_PLATFORM_LIST and added @computed_field moby_slug |
Files not reviewed (1)
- frontend/src/generated/models/PlatformSchema.ts: Language not supported
Comments suppressed due to low confidence (2)
backend/endpoints/responses/platform.py:54
- There are no existing tests for the new
moby_slugcomputed field. Add unit tests to verify correct slug lookup for known platforms and that it returns null whenmoby_idis missing or the slug is not inMOBYGAMES_PLATFORM_LIST.
@computed_field # type: ignore
frontend/src/components/Details/Info/GameInfo.vue:298
- The new “Data provided by” UI block should be covered by component tests to ensure it renders correctly when
rom.is_identifiedis true and hides when false, including all contained anchor links.
<v-row v-if="rom.is_identified">
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots