Hopefully last batch of metadata fixes #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SteamGridDB metadata fetch flow, extends region preferences for ScreenScraper data, and adds JSON decode error handling in the ScreenScraper adapter.
- Replace single-name SGDB lookup with multi-name support in
scan_handler.py - Extend preferred regions list for names, covers, and manuals in
ss_handler.py - Promote
get_details_by_nametoget_details_by_namesinsgdb_handler.pyand adjust logging - Add JSON decoding error handling in the ScreenScraper service
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backend/handler/scan_handler.py | Refactored fetch_sgdb_details and updated SGDB integration |
| backend/handler/metadata/ss_handler.py | Added "eu" and "jp" to region preference arrays |
| backend/handler/metadata/sgdb_handler.py | Renamed lookup method, added iteration over multiple names, adjusted logs,/remove old method |
| backend/adapters/services/screenscraper.py | Handle JSON parsing errors with explicit logging |
Comments suppressed due to low confidence (2)
backend/handler/scan_handler.py:576
- There's a typo in the variable name
sgdb_hander_rom. It would be clearer to rename it tosgdb_handler_romto match the conventional spelling and maintain consistency.
sgdb_hander_rom = await fetch_sgdb_details()
backend/handler/scan_handler.py:554
- The new multi-name lookup logic for SGDB appears untested. Consider adding unit tests for cases where multiple metadata sources provide different game names.
async def fetch_sgdb_details() -> SGDBRom:
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots