Skip to content

fix: watchdog: Only subscribe to relevant filesystem events #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

adamantike
Copy link
Contributor

Description
The watchdog observer supports filtering events based on their type, so unwanted events don't get dispatched.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

The `watchdog` observer supports filtering events based on their type,
so unwanted events don't get dispatched.
@adamantike adamantike requested review from gantoine and zurdi15 July 7, 2025 03:39
Copy link

trunk-io bot commented Jul 7, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

github-actions bot commented Jul 7, 2025

Test Results

168 tests   168 ✅  38s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f147458.

Copy link

github-actions bot commented Jul 7, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7743 4921 64% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f147458 by action🐍

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@adamantike adamantike merged commit b0b97eb into master Jul 7, 2025
9 checks passed
@adamantike adamantike deleted the fix/watchdog-filter-events branch July 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants