Service adapter tests #2058
Merged
Service adapter tests #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive test coverage for service adapters in the RetroAchievements integration, including both unit and integration tests. The tests cover authentication, error handling, API interactions, and a hash calculation service.
- Adds extensive test suite for RetroAchievementsService with both mocked unit tests and real API integration tests
- Implements tests for RAHasherService covering hash calculation, validation, and platform mappings
- Includes VCR cassettes for reproducible API integration testing
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pytest.ini | Adds environment variables for RetroAchievements authentication |
| backend/adapters/services/tests/test_retroachivements.py | Comprehensive test suite for RetroAchievements service with unit and integration tests |
| backend/adapters/services/tests/test_rahasher.py | Tests for hash calculation service, validation regex, and platform mappings |
| backend/adapters/services/tests/cassettes/* | VCR cassettes for reproducible API testing across multiple test scenarios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots