Use URL to store and load search params #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes gallery filter and search state in the URL, replaces direct fetchRoms calls with a unified filterRoms event emitter, and cleans up legacy filter components.
- Sync search and filter state to URL query parameters in
FilterDrawer/Base.vue - Emit
filterRomsinstead of callingfetchRomsdirectly across components - Remove deprecated filter/search components and add explicit setter methods in the gallery filter store
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Gallery/Platform.vue | Emit filterRoms and conditionally reset gallery instead of direct fetch |
| frontend/src/views/Gallery/Collection.vue | Mirror platform changes for collection view |
| frontend/src/stores/galleryFilter.ts | Add setFilterX methods and simplify resetFilters |
| frontend/src/components/Gallery/AppBar/common/FilterTextField.vue | Remove deprecated FilterTextField |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterVerifiedBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterUnmatchedBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterRaBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterPlayablesBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterMissingBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterMatchedBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterFavouritesBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterDuplicatesBtn.vue | Update emitter to filterRoms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue | Implement URL sync and debounce in onFilterChange |
| frontend/src/components/Gallery/AppBar/Search/SearchTextField.vue | Refactor search to emit filterRoms and clear legacy logic |
| frontend/src/components/Gallery/AppBar/Search/SearchBtn.vue | Remove deprecated SearchBtn |
| frontend/src/components/Gallery/AppBar/Platform/Base.vue | Switch to show-search-bar prop instead of show-filter-bar |
| frontend/src/components/Gallery/AppBar/Collection/Base.vue | Switch to show-search-bar prop instead of show-filter-bar |
| frontend/src/components/Gallery/AppBar/Base.vue | Simplify props and drop old filter text field |
Comments suppressed due to low confidence (2)
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue:275
- The new URL parsing and state hydration logic in the
onMountedhook isn't covered by existing tests. Adding unit or integration tests for this behavior would help prevent regressions.
search: urlSearch,
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue
Outdated
Show resolved
Hide resolved
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR does a number of things related to searching and the search page, namely:
Checklist
Please check all that apply.