Fix for setting the correct forward proto when behind ssl proxy #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the X-Forwarded-Proto header reflects the original request scheme when behind an SSL proxy by introducing a conditional mapping.
- Adds an Nginx
mapblock to derive the correct forward protocol ($forwardscheme). - Updates the
proxy_set_header X-Forwarded-Protoline to use the new$forwardschemevariable.
Comments suppressed due to low confidence (2)
docker/nginx/templates/default.conf.template:19
- Consider adding tests (e.g., integration or config linting checks) to verify that
X-Forwarded-Protois correctly set to$forwardschemefor both HTTPS and default ($scheme) scenarios.
proxy_set_header X-Forwarded-Proto $forwardscheme;
docker/nginx/templates/default.conf.template:6
- [nitpick] Consider renaming
$forwardschemeto$forwarded_scheme(snake_case) for improved readability and consistency with common naming conventions.
map $http_x_forwarded_proto $forwardscheme {
| @@ -2,6 +2,12 @@ | |||
| # by using `envsubst` to replace the environment variables in the template with | |||
| # their actual values. | |||
|
|
|||
| # Helper to get scheme regardless if we are behind a prox or not | |||
There was a problem hiding this comment.
Minor typo in the comment: prox should be proxy to correct the spelling.
Suggested change
| # Helper to get scheme regardless if we are behind a prox or not | |
| # Helper to get scheme regardless if we are behind a proxy or not |
Copilot uses AI. Check for mistakes.
adamantike
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1737
Feeds are generated using the "Forward protocol".
This was set to "http" by default in the nginx config, regardless if it is set or not.
This change will set it to
https, if that's what it was set to already, or to$schemeif it's unset.Checklist
Please check all that apply.
[ ] I've added unit tests that cover the changesNot applicable in my opinion.