Skip to content

misc: Upgrade RALibretro to v1.8.1 #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Conversation

adamantike
Copy link
Contributor

Description
The previous attempt to upgrade RALibretro before a new tagged version was available (#1970) needed to be reverted, as the RAHasher tool failed with segmentation faults in some scenarios.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

The previous attempt to upgrade RALibretro before a new tagged version
was available (#1970) needed to be reverted, as the RAHasher tool failed
with segmentation faults in some scenarios.
@adamantike adamantike requested review from gantoine and zurdi15 June 28, 2025 16:13
Copy link

trunk-io bot commented Jun 28, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@adamantike
Copy link
Contributor Author

@gantoine, I tested this new version and wasn't able to trigger any segmentation faults. Feel free to test it on your end!

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant test it since on vacation but should as-is

@adamantike adamantike merged commit 1072973 into master Jun 29, 2025
7 checks passed
@adamantike adamantike deleted the misc/upgrade-ralibretro-1.8.1 branch June 29, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants