Skip to content

misc: Create MobyGames service adapter #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

adamantike
Copy link
Contributor

Description
Add a new service adapter for the MobyGames API, to separate concerns with RomM's handler for metadata.

This adapter is agnostic to the handler and only provides methods to interact with the API, and correctly return typed responses.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Add a new service adapter for the MobyGames API, to separate concerns
with RomM's handler for metadata.

This adapter is agnostic to the handler and only provides methods to
interact with the API, and correctly return typed responses.
@adamantike adamantike requested review from gantoine and zurdi15 June 27, 2025 04:17
Copy link

trunk-io bot commented Jun 27, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

Test Results

91 tests  ±0   91 ✅ ±0   29s ⏱️ -3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4209ee4. ± Comparison against base commit 1321c87.

@adamantike adamantike merged commit 69a2899 into master Jun 27, 2025
9 checks passed
@adamantike adamantike deleted the misc/mobygames-service-adapter branch June 27, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants