Skip to content

misc: Remove _request method from RAHandler #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

adamantike
Copy link
Contributor

Description
This logic was moved to the RetroAchievements service in #1951.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

This logic was moved to the RetroAchievements service in #1951.
@adamantike adamantike requested review from gantoine and zurdi15 June 20, 2025 15:43
Copy link

trunk-io bot commented Jun 20, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

Test Results

92 tests   92 ✅  28s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 8647057.

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

@adamantike adamantike merged commit f4ca097 into master Jun 21, 2025
9 checks passed
@adamantike adamantike deleted the misc/ra-handler-remove-request-method branch June 21, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants