misc: Create ScreenScraper service adapter #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Add a new service adapter for the ScreenScraper API, to separate concerns with RomM's handler for metadata. This adapter is agnostic to the handler and only provides methods to interact with the API, and correctly return typed responses.
b124072 to
da8e7fd
Compare
Test Results92 tests 92 ✅ 32s ⏱️ Results for commit da8e7fd. |
zurdi15
approved these changes
Jun 19, 2025
gantoine
approved these changes
Jun 19, 2025
|
|
||
| SS_DEV_ID: Final = base64.b64decode("enVyZGkxNQ==").decode() | ||
| SS_DEV_PASSWORD: Final = base64.b64decode("eFRKd29PRmpPUUc=").decode() | ||
| LOGIN_ERROR_CHECK: Final = "Erreur de login" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new service adapter for the ScreenScraper API, to separate concerns with RomM's handler for metadata.
This adapter is agnostic to the handler and only provides methods to interact with the API, and correctly return typed responses.
Checklist
Please check all that apply.