misc: Random fixes and improvements #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n multiple components
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR applies a series of minor fixes and improvements across both frontend and backend components. Key changes include refactoring Vue component props and inline styling, renaming and shifting filter logic in the store and API layers, and updating metadata and scanning endpoints for consistency.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Scan.vue | Refactored metadata options retrieval and API call formatting. |
| frontend/src/views/GameDetails.vue, Gallery components | Updated UI components with new props (showPlatformIcon, showActionBar) and improved styling. |
| frontend/src/stores/heartbeat.ts & galleryFilter.ts | Updated store methods and added new filterVerified functionality. |
| frontend/src/services/api/rom.ts | Adjusted API filtering parameters and payload mapping. |
| Various frontend locales | Added translations for "show-verified". |
| Multiple Vue components (e.g., Navigation, MissingFromFSIcon, Game dialogs) | Minor UI improvements including styling and icon updates. |
| Backend handlers & endpoints (scan_handler.py, ra_handler.py, database roms_handler.py, endpoints) | Updated parameter usage and filter renaming, improved RetroAchievements refresh and feed endpoints. |
Test Results92 tests 92 ✅ 29s ⏱️ Results for commit 020e644. ♻️ This comment has been updated with latest results. |
… computed property
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gantoine
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes and improves tiny stuff here and there:
Checklist
Please check all that apply.