Skip to content

fix: Added form rules - Allow ASCII only on create user form #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 16, 2025
Merged

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jun 16, 2025

Description
This PR restricts to ASCII characters only the username, password and email when creating new users.

Aditionally optimized the user and rom edit dialogs with form vuetify object and fixed the fallback covers to preserve aspect ratio.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Closes #1984, #1992

@zurdi15 zurdi15 requested review from gantoine and adamantike June 16, 2025 09:08
@zurdi15 zurdi15 linked an issue Jun 16, 2025 that may be closed by this pull request
@zurdi15 zurdi15 changed the base branch from release to master June 16, 2025 09:08
@zurdi15 zurdi15 self-assigned this Jun 16, 2025
Copy link

trunk-io bot commented Jun 16, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@zurdi15 zurdi15 merged commit 12d8074 into master Jun 16, 2025
9 checks passed
@zurdi15 zurdi15 deleted the romm-1984 branch June 16, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No validation when changing username in settings
2 participants