Hasheous matching #1990
Merged
Hasheous matching #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
44d0770 to
2b1297b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
c02939e to
28d9807
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the Hasheous API as an additional hash-based metadata provider, adding support for retrieving Hasheous and TGDB IDs and metadata that augment existing providers. Key changes include:
- Adding new environment variables, database fields, and indices for hasheous_id and tgdb_id.
- Updating scan handlers and response schemas to incorporate Hasheous metadata.
- Adjusting platform support mappings and related API endpoints to reference the new Hasheous settings.
Reviewed Changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| env.template | Added HASHEOUS_API_ENABLED configuration. |
| backend/utils/generate_supported_platforms.py | Updated platform mapping for Xbox Series renaming. |
| backend/models/rom.py & platform.py | Added fields and indices for hasheous_id and tgdb_id. |
| backend/handler/scan_handler.py | Integrated Hasheous API in platform and ROM scanning logic. |
| backend/handler/metadata/*.py | Added Hasheous handler and updated dependent metadata endpoints and response schemas. |
| backend/endpoints/heartbeat.py, responses/*.py, config/init.py | Updated endpoints to include new Hasheous API support. |
| backend/alembic/versions/0044_hasheous_id.py | Added migration to support new Hasheous fields. |
Files not reviewed (2)
- frontend/src/generated/index.ts: Language not supported
- frontend/src/generated/models/DetailedRomSchema.ts: Language not supported
Comments suppressed due to low confidence (1)
backend/handler/metadata/launchbox_handler.py:266
- The f-string uses nested double quotes around the 'FileName' key, which is likely to cause a syntax error. Consider using single quotes inside the f-string (e.g. best_cover.get('FileName')).
"acorn-archimedes": {"id": 74, "name": "Acorn Archimedes"},
zurdi15
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR integrates the Hasheous API as a hash-based metadata provider. When given a set of hashes, it returns the Hasheous ID, and may return the IGDB, TGDB or RA IDs for that game, if the platform is known.
When enabled, calls to Playmatch and Hasheous happen before other metadata providers, and any returned IGDB/TGDB/RA IDs are used in their respective scanners, preempting calls to filename-based search endpoints.
In it's current form the integration only pulls IGDB/TGDB/RA IDs from hasheous and still requires a connection (i.e. API keys) for IGDB and RA to fetch game information. Future versions will also pull IGDB/RA data from the hasheous proxy once those proxy endpoints are feature complete and ready for use.
Checklist
Please check all that apply.
Screenshots