Fix RA platform IDs for matching #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR corrects and expands platform slug-to-ID mappings for RA and MOBY backends, and adjusts the RA hashing service to reflect some of those changes.
- Fix IDs for existing RA slugs (
ngc,genesis-slash-megadrive,vectrex) - Add new RA slugs (
elektor,fairchild-channel-f,interton-vc-4000,uzebox,wasm-4,win) - Update MOBY handler names for
famicomandsfam
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/handler/metadata/ra_handler.py | Updated several existing IDs, added new slug-to-ID entries |
| backend/handler/metadata/moby_handler.py | Renamed two platform names for better accuracy |
| backend/adapters/services/rahasher.py | Reordered mappings and migrated "win", but new slugs are missing |
Comments suppressed due to low confidence (3)
backend/adapters/services/rahasher.py:56
- The RAHasher mapping is missing several newly introduced slugs (elektor, fairchild-channel-f, interton-vc-4000, uzebox, vectrex). Add them here to keep hashing consistent with ra_handler.
"nds": 18,
backend/handler/metadata/ra_handler.py:336
- Consider adding unit tests for the newly introduced slug-to-ID mappings (e.g.,
elektor,uzebox,win) to verify they resolve correctly during lookup.
+ "elektor": {"id": 75, "name": "Elektor"},
backend/adapters/services/rahasher.py:87
- [nitpick] The slug-to-ID dictionary isn’t sorted alphabetically, which can make future updates harder to locate. Consider sorting keys (or grouping by category) for readability.
"win": 102,
adamantike
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots