Skip to content

feat: Display achievements earned in hardcore mode #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

adamantike
Copy link
Contributor

Description
Differentiate between achievements earned in softcore and hardcore modes, by using the characteristic gold color for hardcore ones.

Also, update the progress bar to show both softcore and hardcore completion percentages.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

image

Differentiate between achievements earned in softcore and hardcore
modes, by using the characteristic gold color for hardcore ones.

Also, update the progress bar to show both softcore and hardcore
completion percentages.
@adamantike adamantike requested review from gantoine and zurdi15 June 11, 2025 01:23
Copy link

trunk-io bot commented Jun 11, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

Test Results

92 tests  ±0   92 ✅ ±0   28s ⏱️ -3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bdc5fa5. ± Comparison against base commit 55b6df5.

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef's kiss

@adamantike adamantike merged commit 51528d8 into master Jun 11, 2025
10 checks passed
@adamantike adamantike deleted the feat/retroachievements-display-hardcore-earned branch June 11, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants