Add fallback for homepage when library is empty #1962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
Adds a fallback empty state to the home view when the user’s library has no content.
- Import and render a new
EmptyHomecomponent inHome.vueunder a combined “library empty” condition. - Introduce three new translation keys (
home-headline,home-title,home-text) in each locale’semptyStates.json. - Create
EmptyHome.vueto display a localized empty-state UI.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Home.vue | Import EmptyHome and add <empty-home> with a compound v-if that checks all library arrays are empty. |
| frontend/src/locales/zh_CN/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/ru_RU/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/ro_RO/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/pt_BR/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/ko_KR/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/ja_JP/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/it_IT/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/fr_FR/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/es_ES/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/en_US/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/en_GB/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/locales/de_DE/emptyStates.json | Add home-headline, home-title, home-text keys. |
| frontend/src/components/Home/EmptyHome.vue | New component rendering the localized empty-state UI. |
Comments suppressed due to low confidence (1)
frontend/src/components/Home/EmptyHome.vue:1
- Add unit tests for
EmptyHome.vueto verify that it correctly renders the localizedheadline,title, andtextbased on the translation keys.
<script setup lang="ts">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots