Skip to content

fix: Iterate through user completion progress in RetroAchievements #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

adamantike
Copy link
Contributor

Description
Iterate through all pages of user completion progress in the RetroAchievements service, instead of limiting the data retrieval to the first 500 results.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@adamantike adamantike requested review from gantoine and zurdi15 June 9, 2025 22:11
Copy link

trunk-io bot commented Jun 9, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

github-actions bot commented Jun 9, 2025

Test Results

92 tests   92 ✅  28s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit a44db97.

♻️ This comment has been updated with latest results.

Iterate through all pages of user completion progress in the
RetroAchievements service, instead of limiting the data retrieval to the
first 500 results.
@adamantike adamantike force-pushed the fix/retroachievements-progress-pagination branch from 43fa65f to a44db97 Compare June 9, 2025 22:19
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@adamantike adamantike merged commit 7285c2b into master Jun 10, 2025
9 checks passed
@adamantike adamantike deleted the fix/retroachievements-progress-pagination branch June 10, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants