Provide Dockerfile for devs #1960
Merged
+223
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
Adds a complete developer Docker setup including an entrypoint script, Dockerfile, and updates to docker-compose and docs to streamline local environment provisioning.
- Introduces
entrypoint.shto bootstrap.env, link frontend assets, and start backend, worker, and frontend processes. - Provides a new
Dockerfilethat installs system dependencies, pyenv, Node via nvm, RAHasher, and Python tooling. - Updates
docker-compose.ymlwith aromm-devservice, default env fallbacks, and exposes ports for all containers. - Adjusts
DEVELOPER_SETUP.mdto reference the new container names.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| entrypoint.sh | New script to initialize environment and launch services |
| docker-compose.yml | Added romm-dev service, default fallbacks, and fixed port mappings |
| Dockerfile | Added image build steps for dependencies, pyenv, nvm, and project setup |
| DEVELOPER_SETUP.md | Updated example commands to use renamed containers |
Comments suppressed due to low confidence (4)
docker-compose.yml:19
- This volume line omits the host:container mapping. Specify both sides (e.g.,
./romm_mock:/app/backend/romm_mock) to ensure the correct directory is mounted.
- /app/backend/romm_mock # Empty directory
docker-compose.yml:21
- Missing host:container syntax here—add a host path (e.g.,
./frontend/node_modules:/app/frontend/node_modules) so the volume mounts correctly.
- /app/frontend/node_modules # Empty directory
docker-compose.yml:22
- This entry lacks the host side of the mount. It should follow
host_path:container_pathformat (for example./frontend/dist:/app/frontend/dist).
- /app/frontend/dist # Empty directory
docker-compose.yml:59
- [nitpick] The service is named
romm-postgres-devbut the container isromm-postgresql-dev; consider aligning these for consistency.
container_name: romm-postgresql-dev
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR provides a Dockerfile and container devs can run to quick start development on their local machine, without having to install all the required dependencies.
Fixes #1954
Checklist
Please check all that apply.
Screenshots