[ROMM-1943] Consistent use of click handlers #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to standardize event handler bindings by removing unnecessary empty parentheses so that the $event can be accessed when needed. Key changes include:
- Removing empty parentheses from click and keyup event handlers across various Vue components.
- Updating a translation key in the EditRom component.
- Adding a margin class to an element in PlatformInfoDrawer for alignment consistency.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/common/Game/Dialog/MatchRom.vue | Removed empty parentheses from @keyup.enter and @click handlers. |
| frontend/src/components/common/Game/Dialog/EditRom.vue | Updated @keyup.enter and @click bindings; changed translation key from "rom.foldername" to "rom.folder-name" and removed a possibly redundant keyup handler. |
| frontend/src/components/common/Game/AdminMenu.vue | Removed empty parentheses from @click handler. |
| frontend/src/components/common/Collection/Dialog/CreateCollection.vue | Removed empty parentheses from @keyup.enter bindings. |
| frontend/src/components/Settings/Administration/Users/Dialog/DeleteUser.vue | Removed empty parentheses from the @click handler. |
| frontend/src/components/Settings/Administration/Users/Dialog/CreateUser.vue | Removed empty parentheses from the @click handler. |
| frontend/src/components/Gallery/FabOverlay.vue | Removed empty parentheses from the @click handler. |
| frontend/src/components/Gallery/AppBar/common/SelectingBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/GalleryViewBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterUnmatchedBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterRaBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterPlayablesBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterMatchedBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterFavouritesBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/FilterDuplicatesBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/common/FilterBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/Platform/PlatformInfoDrawer.vue | Removed empty parentheses from event handlers and added a margin class for alignment. |
| frontend/src/components/Gallery/AppBar/Platform/FirmwareBtn.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/Platform/Base.vue | Removed empty parentheses from @click binding. |
| frontend/src/components/Gallery/AppBar/Collection/CollectionInfoDrawer.vue | Removed empty parentheses from event handlers and added a margin class for alignment. |
Comments suppressed due to low confidence (2)
frontend/src/components/common/Game/Dialog/EditRom.vue:232
- [nitpick] Verify that the updated translation key 'rom.folder-name' is intentional and consistent with the naming conventions in the translation files.
:label="rom.multi ? t('rom.folder-name') : t('rom.filename')"
frontend/src/components/common/Game/Dialog/EditRom.vue:235
- Confirm that the removal of the @keyup.enter handler in this input is deliberate and that it won't affect the expected behavior of updating the ROM when the Enter key is pressed.
@keyup.enter="updateRom"
zurdi15
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
For callback functions where we don't pass params, remove the empty
()so we can access the$eventis needed.Checklist
Please check all that apply.
Screenshots