Skip to content

fix: Remove critical log messages for 403 and 404 exceptions #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

adamantike
Copy link
Contributor

Description
These critical log messages are unnecessary and can clutter the logs, based on user requests. This is even more notorious when RomM is integrated to an error tracking system like Sentry.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

These critical log messages are unnecessary and can clutter the logs,
based on user requests. This is even more notorious when RomM is
integrated to an error tracking system like Sentry.
@adamantike adamantike requested review from gantoine and zurdi15 June 7, 2025 00:43
Copy link

trunk-io bot commented Jun 7, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

github-actions bot commented Jun 7, 2025

Test Results

92 tests   92 ✅  31s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 9ba787f.

@adamantike adamantike changed the base branch from release to master June 7, 2025 14:43
@adamantike adamantike merged commit 7ccd0f8 into master Jun 7, 2025
9 checks passed
@adamantike adamantike deleted the fix/no-critical-log-on-403-404 branch June 7, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants