v3.10.1 #1938
Merged
v3.10.1 #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[HOTFIX] Fix ramatcher on mult-file games
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Test Results92 tests 92 ✅ 28s ⏱️ Results for commit fd18d8e. ♻️ This comment has been updated with latest results. |
fixed typos
Update README.md
Cleanup lingeting t_thumb in cover and screenshto art
There was a problem hiding this comment.
Pull Request Overview
This PR (v3.10.1) introduces several small enhancements and fixes across the codebase. Key changes include:
- Adding RA ID handling in scan functions for enhanced retro achievements support.
- Adjusting file paths for multi-disk ROMs in hash generation.
- Updating regex validation in RAHasher and correcting grammar in log messages.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| backend/handler/scan_handler.py | Adds RA ID support and reorders dictionary keys in scan functions. |
| backend/handler/filesystem/roms_handler.py | Updates file path concatenation to account for multi-disk ROMs. |
| backend/handler/filesystem/resources_handler.py | Improves error message formatting for cover removal. |
| backend/endpoints/sockets/scan.py | Adjusts default values and metadata handling for RA fields. |
| backend/alembic/versions/0041_assets_t_thumb_cleanup.py | Adds a migration script to update media URLs from t_thumb to higher resolutions. |
| backend/adapters/services/rahasher.py | Changes regex validation and adds error handling for RAHasher subprocess calls. |
| README.md | Fixes typos and clarifies feature descriptions. |
Comments suppressed due to low confidence (1)
backend/adapters/services/rahasher.py:127
- The updated regex no longer uses anchors, which may allow partial matches. If strict validation of a 32-character hash is intended, consider reverting to anchored regex (e.g., r"^[0-9a-f]{32}$").
match = RAHASHER_VALID_HASH_REGEX.search(file_hash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots