[HOTFIX] Fix ramatcher on mult-file games #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a hotfix for mult-file games by updating the RAHasher invocation to support folder-based file matching and improving hash extraction from RAHasher's output.
- Uses the folder/* syntax when invoking RAHasher for mult-file games
- Updates the regex usage to extract and validate hashes from RAHasher's output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/handler/filesystem/roms_handler.py | Adjusts file path handling to support mult-file folders |
| backend/adapters/services/rahasher.py | Modifies hash extraction to use substring search with an updated regex pattern |
Comments suppressed due to low confidence (1)
backend/adapters/services/rahasher.py:127
- The removal of string anchors in the regex may allow unintended substrings to be matched; please verify that this behavior aligns with the intended design.
match = RAHASHER_VALID_HASH_REGEX.search(file_hash)
zurdi15
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
The core of this change is using the
folder/*syntax when running the contents of a folder thought rahasher, plus searching all output lines for a matching hash. Parsing compressed files is still not supported.Checklist
Please check all that apply.