v3.10.0 #1928
Merged
v3.10.0 #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/retro_achievements
…ve from UserInterface
- Implemented RA hash handling in ROM processing. - Added functionality to refresh RetroAchievements data for users. - Updated user model to store RA progression data. - Created a new component for managing RetroAchievements settings in user profiles. - Enhanced ROM metadata to include merged RA achievements and badge paths. - Refactored API calls to accommodate new RA features and removed unused API key handling. - Updated frontend components to reflect changes in RA metadata and user settings. - Adjusted Docker configuration for database service naming.
feat: Added optional 3D tilt effect to cards
…Platform components
…r and SettingsDrawer" This reverts commit 415f8d5.
…buting to the docs'
…buting to the Docs'
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This release introduces RetroAchievements support, enhances log output formatting with highlights, and updates documentation and configuration for the new feature.
- Add
ra_usernameandra_progressionto user schemas, forms, migrations, and config - Integrate highlight-based logging (
hl) across multiple endpoints for improved readability - Update README and contributing guides to reference the new docs site and badges
Reviewed Changes
Copilot reviewed 274 out of 274 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| backend/endpoints/responses/identity.py | Added ra_username/ra_progression fields and RAProgression TypedDict |
| backend/endpoints/heartbeat.py | Exposed RA_ENABLED in heartbeat response |
| backend/endpoints/auth.py | Added /forgot-password and /reset-password endpoints |
| backend/adapters/services/rahasher.py | Changed calculate_hash signature and error handling logic |
| README.md | Swapped wiki links and badges for new docs site |
Comments suppressed due to low confidence (4)
backend/endpoints/auth.py:279
- The new
/forgot-passwordand/reset-passwordendpoints lack accompanying unit tests; consider adding tests to verify both successful and failure flows.
def request_password_reset(username: str = Body(..., embed=True)) -> MessageResponse:
backend/endpoints/firmware.py:222
- The variable
firmare_idsappears to be a typo; rename it tofirmware_idsfor clarity and consistency.
firmare_ids: list = data["firmware"]
backend/endpoints/heartbeat.py:30
- The key
RA_ENABLEDis inconsistent with other source flags (e.g.,IGDB_API_ENABLED); consider renaming toRA_API_ENABLEDfor uniform naming.
RA_ENABLED: bool
backend/adapters/services/rahasher.py:92
- Changing the method signature from
(platform_slug: str, file_path: Path)to(platform_id: int, file_path: str)may break existing callers; ensure all usages are updated or maintain backward compatibility.
async def calculate_hash(self, platform_id: int, file_path: str) -> str:
Test Results92 tests 92 ✅ 32s ⏱️ Results for commit 3c2f320. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Checklist
Please check all that apply.
Screenshots