feat: Added optional 3D tilt effect to cards #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
gantoine
approved these changes
May 27, 2025
Comment on lines
+44
to
+52
| const isHovering = ref(false); | ||
| const hoveringRomId = ref(); | ||
| const openedMenu = ref(false); | ||
| const openedMenuRomId = ref(); | ||
| const storedEnable3DEffect = localStorage.getItem("settings.enable3DEffect"); | ||
| const enable3DEffect = ref( | ||
| isNull(storedEnable3DEffect) ? false : storedEnable3DEffect === "true", | ||
| ); | ||
| let timeout: ReturnType<typeof setTimeout>; |
There was a problem hiding this comment.
this is duplicated like 5 times, we should probably (not in this PR) make this a utility
There was a problem hiding this comment.
Actually I wanted this to be merged because my plan is to create a pinia store for settings. That will avoid this being duplicated everywhere. Also the handlers can be extracted to a utility too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added optional 3D tilt effect for cards when hover on them
Checklist
Please check all that apply.
Screenshots