Fetch games in pagniated chunks #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements paginated fetching of game metadata and adds a GitHub Actions workflow for building and packaging the extension.
- Replace single large request with batched requests (limit = 72) and offset loop
- Improved logging per batch and aggregated results
- Added
.github/workflows/build.ymlto automate build, package, and artifact upload on version tags
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| RomM.cs | Introduced pageSize, offset, batching loop, and accumulated allRoms list |
| .github/workflows/build.yml | New CI workflow for building, packaging, and uploading the extension on tag pushes |
Comments suppressed due to low confidence (1)
RomM.cs:263
- The new pagination loop isn’t covered by existing tests. Add unit or integration tests to verify multi-page behavior, cancellation, and error handling.
while (hasMoreData)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fetches the roms for each platform in batches of 72, so we're no longer limited to pulling 2500 roms/platform.
Fixed #52