Skip to content

Filter registered ROMs by emulator profile supported file types #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 19, 2024
Merged

Filter registered ROMs by emulator profile supported file types #28

merged 7 commits into from
Nov 19, 2024

Conversation

ryanpf
Copy link
Contributor

@ryanpf ryanpf commented Oct 22, 2024

Fixes #22

@gantoine gantoine self-requested a review November 15, 2024 15:27
gantoine
gantoine requested changes Nov 16, 2024
View reviewed changes
gantoine
gantoine approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the PR!!

@gantoine gantoine merged commit 4e6a3ac into rommapp:main Nov 19, 2024
@ryanpf ryanpf deleted the fix/rom-import-only-supported-file-types branch November 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] If platform is PS3, only add specific file as the rom
2 participants
@ryanpf @gantoine