Skip to content

Conversation

DevYukine
Copy link
Contributor

@DevYukine DevYukine commented Jul 22, 2024

Changes

  • Replace Newtonsoft JArray/JObject to avoid reflection and use typed objects for everything (huge performance boost)
  • Return the whole array in GetGames instead yielding over the array because it has no advantage here
  • Simplify LINQ queries to avoid doing Where().Any() and Where().FirstOrDefault()
  • Streaming the roms http body response as for big libraries reading the whole body into memory directly is more memory inefficient
  • Invert if logic in SettingsView to reduce nesting (8c41cda)
  • Bump Netwonsoft from v10 -> v13, there are no relevant breaking changes for this plugin (4359f07) Reverted because of incompatibility with Playnite
  • Add Region, Revision and Tags into the Game name to make it easy inside Playnite to difference between multiple version of the same game

@gantoine gantoine self-requested a review July 22, 2024 19:24
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks dope! just a couple questions/comments

@gantoine gantoine merged commit 6cb59e3 into rommapp:main Aug 2, 2024
@DevYukine DevYukine deleted the feature/performance-and-improvements branch August 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants