Skip to content

Fixes after sdl2 merge #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

Fixes after sdl2 merge #39

merged 6 commits into from
Apr 4, 2025

Conversation

JeodC
Copy link
Contributor

@JeodC JeodC commented Apr 2, 2025

Description

  • Resolve typos in api.py preventing filesystem method from being called
  • Send python tracebacks to $LOG_FILE
  • Log system set for YMD, not HMS to prevent polluting log folder too much
  • Add missing else clause to input.py
    • Remove logging button presses from input.py (not needed after debug)

Downloading from the demo host was successful with emulationstation:

Loaded controller mapping from environment
Found 1 controller(s)
Found game controller 0: Retroid Pocket Gamepad
ROMs path: /storage/roms
Fetched 9 platforms
Fetching: https://demo.romm.app/api/roms/198/content/AroachInSpace.bin?hidden_folder=true
Downloading A Roach in Space to /storage/roms/atari2600/AroachInSpace.bin
Finalized download
Exiting...

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR

- Resolve typos in api.py preventing filesystem method from being called
- Send python tracebacks to $LOG_FILE
- Log system set for YMD, not HMS to prevent polluting log folder too much
- Add missing else clause to input.py
@gantoine gantoine merged commit e6064b6 into rommapp:main Apr 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants