Select all roms button #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
reviewed
Mar 25, 2025
RomM/romm.py
Outdated
| for r in self.status.roms_to_show: | ||
| self.status.multi_selected_roms.append( | ||
| r | ||
| ) |
There was a problem hiding this comment.
Does this mean select all only select the 10-ish games shown in the screen, instead of the entire library? Not that I'm saying it should btw.
There was a problem hiding this comment.
Hi, the entire (filtered) selected library
There was a problem hiding this comment.
It's useful to download the entire platform roms, expecially with the filter set to remote.
There was a problem hiding this comment.
Cool going pull this branch and give it a shot 👍🏼
|
@ronzano Made some small tweaks to the PR, can you pull and lmk what you think?
|
|
Looks good. I noticed a strange behavior: |
gantoine
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Select /Unselect all roms button on R1
Checklist
Toggle button to select/unselect all roms