Skip to content

Fix incorrect scaling on exit #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

Fix incorrect scaling on exit #31

merged 2 commits into from
Mar 20, 2025

Conversation

sargunv
Copy link
Contributor

@sargunv sargunv commented Mar 20, 2025 •
edited
Loading

Fixes #28

Description

Since the app scales at 640x480, but the rg34xx has a 720x480 display, we need to FB_SWITCH after exit to restore the system scaling to normal.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR

Screenshots

@sargunv sargunv marked this pull request as ready for review March 20, 2025 00:32
gantoine
gantoine approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! will give it a shot 👍🏼

@gantoine gantoine merged commit 9e042ce into rommapp:main Mar 20, 2025
1 check passed
@sargunv sargunv deleted the fix-exit-scaling branch March 20, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] MuOS menu and games are incorrectly scaled and cut off after opening and closing Romm app on RG34XX
2 participants
@sargunv @gantoine